Require Node 24 #86
Require Node 24 #86
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the minimum required Node.js version from 22 to 24, which is a major breaking change reflected in the semantic version bump from 9.3.2 to 10.0.0. The changes primarily focus on:
- Removing version-specific compatibility code: Tests that previously checked the Node.js version and conditionally ran different code paths have been simplified to only support Node 24+ features
- Updating all dependency versions: ESLint, TypeScript-ESLint, and other development dependencies have been updated to their latest versions
- Upgrading build tooling: esbuild and related peer dependencies have been updated to version 0.27.0
Key Changes:
- Node.js features that were previously gated behind version checks (like duplicate named capturing groups in RegEx, Float16Array, RegExp.escape, and Promise.try) are now unconditionally available
- Test scripts have been simplified by removing the need for version detection
- Documentation has been updated to reflect the new minimum version requirement
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/node/node-24.spec.ts | Removed version check wrapper around Node 24 feature tests |
| src/test/lib/es2026.spec.ts | Removed version check wrapper around ES2026 feature tests |
| src/test/lib/es2025.spec.ts | Removed conditional logic for Node 22 vs Node 24, now only testing Node 24+ features; contains missing assertions |
| package.json | Major version bump to 10.0.0, updated Node engine requirement to >=24.11, updated peer dependencies and dev dependencies |
| package-lock.json | Comprehensive dependency updates reflecting the package.json changes |
| SECURITY.md | Updated supported version table to reflect 10.x as the current supported version |
| README.md | Updated minimum Node.js version documentation from 22.15 to 24.11 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Beta Published - Install Command: |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❌ PR review status - has 1 reviewer outstanding |
Fixes #85