fix(ingress): ingress causing continuous error logs#68
Open
sujaya-sys wants to merge 2 commits intomainfrom
Open
fix(ingress): ingress causing continuous error logs#68sujaya-sys wants to merge 2 commits intomainfrom
sujaya-sys wants to merge 2 commits intomainfrom
Conversation
Moves the enabled annotation check before gatherApiCheckData() to prevent errors when ingresses lack required group annotation. Fixes regression from #49 where disabled ingresses were causing continuous error logs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
sujaya-sys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for regression from #65 where disabled ingresses were causing continuous error logs.
TL;DR: Moves the enabled annotation check before gatherApiCheckData() to prevent errors when ingresses lack required group annotation.
Confirmed locally: Ingresses without enabled annotation are silently ignored, no errors.
Note
This PR was created with the help of Claude, please let me know if I'm on the wrong path here.