Conversation
nodchip
reviewed
Mar 25, 2024
| def reverseList(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| if not head: | ||
| return None | ||
| node_list = [] |
Owner
Author
There was a problem hiding this comment.
そうですね！ありがとうございます.
あとから見て_listは右辺の代入があるから要らないなと気付きました.
| cursor = head | ||
| prev_node = None | ||
| while cursor: | ||
| tmp = cursor.next |
There was a problem hiding this comment.
tmp は何も表さないため、個人的には避けています。ですが、この規模のコードであれば問題ないかもしれません。
Owner
Author
There was a problem hiding this comment.
next_nodeという名前も考えていたのですが, どなたかのコメントで"prevもnextも出てくると混乱するのでは"とあったためこの命名にしました. おっしゃるとおり, 大きい規模のコードでは避けるようにします.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem link