Conversation
nodchip
reviewed
Mar 17, 2024
| @@ -0,0 +1,34 @@ | |||
| class Solution: | |||
| def getCharFromUnitPos(self, s: str, numRows: int, unitIndex: int, position: int) -> str | None: | |||
There was a problem hiding this comment.
Python では一般には関数名・変数名は lower snake で書くと思います。詳しくは PEP8 をご覧ください。
ただ、 LeetCode のコードのひな形に合わせるのであれば、仕方ないと思います。
Owner
Author
There was a problem hiding this comment.
ありがとうございます！この解答は昔書いたものなので覚えていないのですが, おそらくleetcodeに合わせてこのケースを採用したものと思います. snake_caseを採用するよう意識します.
| class Solution: | ||
| def getCharFromUnitPos(self, s: str, numRows: int, unitIndex: int, position: int) -> str | None: | ||
| assert numRows >= 2 | ||
| numChars = 2 * numRows - 2 |
There was a problem hiding this comment.
numChars が何を表すのか分かりませんでした。 unitLength あたりはいかがでしょうか？
Owner
Author
There was a problem hiding this comment.
ありがとうございます, おっしゃる通りですね. 他にもanswerといった変数名を使っており良くないですね.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem link
参照した他の解答についてはnote.mdに記載しております.