Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Python bindings for several methods (options, rank_of, loc_of, neighbor_rank) to layout implementation classes, and fixes a bug where the __repr__ lambda parameter for CubedLayout incorrectly referenced CubedSphereLayoutImpl instead of CubedLayoutImpl.
Changes:
- Added Python bindings for
options,rank_of,loc_of, andneighbor_ranktoLayoutImpl,SlabLayoutImpl,CubedLayoutImpl, andCubedSphereLayoutImpl - Fixed the lambda parameter type in
CubedLayout.__repr__fromCubedSphereLayoutImpltoCubedLayoutImpl
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .def("__repr__", [](const snap::CubedLayoutImpl &self) { | ||
| std::stringstream ss; | ||
| self.pretty_print(ss); | ||
| return fmt::format("CubedSphereLayout(\n{})", ss.str()); |
There was a problem hiding this comment.
The repr method for CubedLayout incorrectly returns a string labeled as "CubedSphereLayout". It should return "CubedLayout" instead to match the actual class name. This inconsistency could confuse users when inspecting CubedLayout objects.
Suggested change
| return fmt::format("CubedSphereLayout(\n{})", ss.str()); | |
| return fmt::format("CubedLayout(\n{})", ss.str()); |
Contributor
|
🎉 Released v1.3.1! What's Changed
Full Changelog: v1.3.0...v1.3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.