Modify some code to run on windows system.#139
Open
Anm-pinellia wants to merge 5 commits intochengtan9907:OpenSTL-Lightningfrom
Open
Modify some code to run on windows system.#139Anm-pinellia wants to merge 5 commits intochengtan9907:OpenSTL-Lightningfrom
Anm-pinellia wants to merge 5 commits intochengtan9907:OpenSTL-Lightningfrom
Conversation
Anm-pinellia
commented
May 31, 2024
Anm-pinellia
commented
- Fix the problem of creating and reading temporary file in windows.
- To use 'auto' strategy as the default strategy to avoid nccl Exception.
Fix the problem of current trainer cannot parser corresponding dataloaders.
modify some code to make it compatible with windows. Specifically, after opening a temporary file, windows system will remove it after close it. So it needs to modify some params during create the temporayfile. (e.g. delte=False, open and delete temporaryfile manually)
modify some code to make it compatible with windows. Specifically, after opening a temporary file, windows system will remove it after close it. So it needs to modify some params during create the temporayfile. (e.g. delte=False, open and delete temporaryfile manually)
make it easy to debug, instead of giving a print. (Config file should be prior than arguments, which can be seen in mmopenlab frameworks).
To compatible with windows, default strategy should better to be auto rather than ddp. (windows only support gloo instead of nccl to manage gpus).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.