Skip to content

Fix Bremsstrahlung trapezium indexing #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsnever merged 1 commit into from
Nov 9, 2022
Merged

Fix Bremsstrahlung trapezium indexing #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ New:

Bug Fixes:
----------
* Fixed Bremsstrahlung trapezium evaluation (#384).
* Fixed generomak plasma edge data paths.
* Fix and improve OpenCL utility functions. (#358)

Expand Down
2 changes: 1 addition & 1 deletion cherab/core/model/plasma/bremsstrahlung.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ cdef class Bremsstrahlung(PlasmaModel):
lower_sample = self._bremsstrahlung(lower_wavelength, te, ne, z_effective)
for i in range(spectrum.bins):

upper_wavelength = spectrum.min_wavelength + spectrum.delta_wavelength * i
upper_wavelength = spectrum.min_wavelength + spectrum.delta_wavelength * (i + 1)
upper_sample = self._bremsstrahlung(upper_wavelength, te, ne, z_effective)

spectrum.samples_mv[i] += 0.5 * (lower_sample + upper_sample)
Expand Down