Skip to content

Look up in cherab.core.atomic.elements instead of using _popular_species and _species_symbol_map dicts #33

@vsnever

Description

@vsnever

I suggest that instead of using _popular_species dict when reading the data from raw or balance files, we should search for the matches in cherab.core.atomic.elements. First, get all isotopes with a given nuclear charge, second, from them find the one with the closest atomic mass to the given one.

Similarly, _species_symbol_map dict must be replaced with the search for the matching element symbol in cherab.core.atomic.elements. Extracting the nuclear charge from the balance file also must be improved the same way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions