fix(fix-request-body): support '+json' content-type suffix#1015
Merged
Conversation
Owner
|
Thank you so much for your time spent on this improvement; with detailed problem description, reference to RFC spec, creating the solution and accompanied by unit-tests. This is how you do a PR! 🙏 Thanks @howiezhao! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance
fixRequestBodymethod to fixContent-Typeincludes+jsonMotivation and Context
Now, if our Media Type includes
+jsonbut does not includesapplication/json, thefixRequestBodymethod will not work. For example, the Media Type isapplication/merge-patch+json.According to RFC 6838, the
+suffix indicates a structured type. Therefore, for the Media Type includes+json, we can directly serialize it to JSON.This PR fixes the issue where the
fixRequestBodymethod does not work for Media Types includes+json, such asapplication/merge-patch+json.How has this been tested?
Unit Test
Types of changes
Checklist: