Skip to content

yarn upgrade @types/http-proxy#1023

Closed
antiBaconMachine wants to merge 1 commit into
chimurai:masterfrom
antiBaconMachine:bump-http-proxy-type
Closed

yarn upgrade @types/http-proxy#1023
antiBaconMachine wants to merge 1 commit into
chimurai:masterfrom
antiBaconMachine:bump-http-proxy-type

Conversation

@antiBaconMachine
Copy link
Copy Markdown

@antiBaconMachine antiBaconMachine commented Aug 7, 2024

Description

Recently I noticed that the method option was missing from the http-proxy serverOptions type. I've submitted a patch for the type DefinitelyTyped/DefinitelyTyped#70173, this PR simply bumps the dependency version for the type so we can use it with this module.

How has this been tested?

The functionality already worked as options are just passed through to http-proxy. It just caused a typescript error. We no longer get typescript errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chimurai
Copy link
Copy Markdown
Owner

Thanks @antiBaconMachine for improving @types/http-proxy 👍

Included your update in: #1026

Instead of updating the lock file; I've updated the patch version to make sure consumers will get the latest patch version.

@chimurai chimurai closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants