Skip to content

fix(logger-plugin): handle undefined protocol and hostname #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chimurai merged 1 commit into from
Sep 3, 2024
Merged

fix(logger-plugin): handle undefined protocol and hostname #1036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/plugins/default/logger-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,30 @@ export const loggerPlugin: Plugin = (proxyServer, options) => {
const originalUrl = req.originalUrl ?? `${req.baseUrl || ''}${req.url}`;

// construct targetUrl
const port = getPort(proxyRes.req?.agent?.sockets);
let target: URL;

const obj = {
protocol: proxyRes.req.protocol,
host: proxyRes.req.host,
pathname: proxyRes.req.path,
} as URL;
try {
const port = getPort(proxyRes.req?.agent?.sockets);

const target = new URL(`${obj.protocol}//${obj.host}${obj.pathname}`);
const obj = {
protocol: proxyRes.req.protocol,
host: proxyRes.req.host,
pathname: proxyRes.req.path,
} as URL;

if (port) {
target.port = port;
target = new URL(`${obj.protocol}//${obj.host}${obj.pathname}`);

if (port) {
target.port = port;
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
} catch (err) {
// nock issue (https://github.com/chimurai/http-proxy-middleware/issues/1035)
// fallback to old implementation (less correct - without port)
target = new URL(options.target as URL);
target.pathname = proxyRes.req.path;
}

const targetUrl = target.toString();

const exchange = `[HPM] ${req.method} ${originalUrl} -> ${targetUrl} [${proxyRes.statusCode}]`;
Expand Down