Skip to content

test(types.spec.ts): add type check when req or res are 'any' #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chimurai merged 1 commit into from
Feb 7, 2026
Merged

test(types.spec.ts): add type check when req or res are 'any' #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/types.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ describe('http-proxy-middleware TypeScript Types', () => {
error(error, req, res, target) {
req.params;

// @ts-expect-error: should error when request is typed as `any`
req.unknownProperty;
// @ts-expect-error: should error when response is typed as `any`
res.unknownProperty;

// https://www.typescriptlang.org/docs/handbook/2/narrowing.html
if (res instanceof http.ServerResponse) {
res.status(200).send('OK');
Expand Down Expand Up @@ -345,6 +350,11 @@ describe('http-proxy-middleware TypeScript Types', () => {
proxyRes: responseInterceptor(async (buffer, proxyRes, req, res) => {
req.myRequestParams;
res.myResponseParams;

// @ts-expect-error: should error when request is typed as `any`
req.unknownProperty;
// @ts-expect-error: should error when response is typed as `any`
res.unknownProperty;
return buffer;
}),
},
Expand All @@ -371,6 +381,12 @@ describe('http-proxy-middleware TypeScript Types', () => {
(proxyServer, options) => {
proxyServer.on('proxyReq', (proxyReq, req, res, options) => {
req.params;

// @ts-expect-error: should error when request is typed as `any`
req.unknownProperty;
// @ts-expect-error: should error when response is typed as `any`
res.unknownProperty;

res.status(200).send('OK');
});
},
Expand All @@ -396,6 +412,12 @@ describe('http-proxy-middleware TypeScript Types', () => {
responseInterceptor(async (buffer, proxyRes, req, res) => {
req.params;
res.status(200).send('OK');

// @ts-expect-error: should error when request is typed as `any`
req.unknownProperty;
// @ts-expect-error: should error when response is typed as `any`
res.unknownProperty;

return buffer;
}),
);
Expand Down
Loading