crashes on include DEFINE_CHECK()

[mikofski]

thanks for this effort. I can't get it to build.

error message: dbus/dbus.h can't be found in validation.c line 33 of dbus-python.h, and others, stdint.h can't be found in unixfd.c on line 27 of types-internal.h

if I change path to remove dbus, then it crashes on the macro DEFINE_CHECK()

expected: build _dbus_binding.pyd DLL extension for python
current: doesn't build

system: windows xp, dbus 1.6.2 compiled and tested using msvc100, dbus_glib-0.100 compiled with mingw, and python 2.7.3

settings
DBUS_GLIB_LIBRARY:FILEPATH=C:/MinGW/msys/1.0/local/lib/libdbus-glib-1.a
DBUS_INCLUDE_DIR:PATH=C:/Program Files/dbus/include/dbus
DBUS_INCLUDE_LIB_DIR:PATH=C:/Program Files/dbus/include/dbus
DBUS_LIBRARY:FILEPATH=C:/Program Files/dbus/lib/dbus-1.lib
GLIB_CONFIG_INCLUDE_DIR:PATH=C:/Python27/Lib/site-packages/gtk-2.0/runtime/lib/glib-2.0/include
GLIB_INCLUDE_DIR:PATH=C:/Python27/Lib/site-packages/gtk-2.0/runtime/include/glib-2.0
GLIB_LIBRARIES:FILEPATH=C:/Python27/Lib/site-packages/gtk-2.0/runtime/lib/glib-2.0.lib
PKG_CONFIG_EXECUTABLE:FILEPATH=C:/Python27/Lib/site-packages/gtk-2.0/runtime/bin/pkg-config.exe

[choeger]

Hmm did you set those DBUS paths manually? Actually they should come without the dbus/ suffix (as that is always in the include directive).

Also I do not understand the stdint error. There should be a test against it (Microsoft does not implement C99 so you need to get a stdint.h on your own).

I've just pushed a lot of changes, could you retry?

[mikofski]

I changed the path, which fixed the "can't include dbus/dbus.h" issue. Changing inline to __inline solved the macro issues, eg at DEFINE_CHECK and others. like Ralf Habacker I commented out stdint.h, although that may be causing new issues. Are you staying current with upstream? Have you looked at Ralf Habacker's patches from the KDE windows initiative in the testings section? I'll pull your latest changes and try again. I'm using vc90 since that's what python is compiled against, but I could also use vc100.

Sent via Hubroid

[choeger]

I don't think you should do anything manually. CMake should find dbus for you and also complain if there is no stdint.h. Also the inline stuff should be fixed in HEAD.