Adds a newline at the very end of the authorized_keys file #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is important because it allows new keys to be added via `cat ... >> ~/.ssh/authorized_keys` or `echo ... >> ~/.ssh/authorized_keys` Without a newline at the end of the file `>>` will concat text to the end of the last key, mangling the file. * These modifications should handle files that currently do *and* do not have newlines at the very end, though it will always write files that *do* have newlines at the very end.
Owner
There was a problem hiding this comment.
I think we still want a newline if content.empty?
Owner
There was a problem hiding this comment.
Actually - scratch that. We don't need a newline if the content is empty 😄
Owner
|
Just a couple quick notes, but looks awesome ❤️ |
Owner
There was a problem hiding this comment.
Might need to update this test to satisfy keys_file.rb#L60
content = keys_file.read
expect(content).to end_with("\n") unless content.empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have newlines at the very end, though it will always write files
that do have newlines at the very end.