Add buildifier linting to CI and improve formatting documentation#7
Merged
Add buildifier linting to CI and improve formatting documentation#7
Conversation
- Add buildifier check step to GitHub Actions CI workflow with lint_mode - Configure buildifier targets in tools/format/BUILD.bazel: - //tools/format:buildifier - for fixing formatting and lint issues - //tools/format:buildifier.check - for CI checks (warns without modifying) - Update DEVELOPMENT.md with comprehensive lint documentation https://claude.ai/code/session_014vXCKU78Q6L4Ru68ogafN7
- Consolidate formatting and linting into format_multirun with starlark_fix_args and starlark_check_args for lint mode - Add root alias for convenient `bazel run //:format` usage - Update CI to use //tools/format:format.check as recommended - Simplify documentation to reflect the unified approach Reference: https://github.com/aspect-build/rules_lint/blob/main/docs/formatting.md https://claude.ai/code/session_014vXCKU78Q6L4Ru68ogafN7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aspect_rules_lintformat_multirunwith lint mode following official docsaspect_rules_lintto 2.0.0bazel run //:formatusageChanges
CI Integration
//tools/format:format.checkwhich checks both formatting and lint warningsFormatting Setup (
tools/format/BUILD.bazel)format_multirunwithstarlark_fix_args = ["--lint=fix"]andstarlark_check_args = ["--lint=warn"]Developer Experience
//:formatalias in root BUILD.bazel for easy accessUsage