Open
Conversation
added 2 commits
May 5, 2016 09:13
Great to see so may comments. They really help describe your app.
Using a helper file like this makes this app stand out from the crowd! Well done. The only thing I'd do is maybe add a few comments at the start of the file explaining what you are doing in this file and may be a break down of the methods and their corresponding line number.That way if you were to had this to another dev they could quickly find methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excellent app! Well done this is such a good effort for one weeks work. This app really does have real world application.
Your code is well written, indented and concise. What else can I say.
Things I'd do before the meet and great.
Polish the read me file. Maybe add a screen shot of your prototyping and maybe a user test case.
Nice one!