Chromie/fix deprecate model to provider map#3
Merged
chromiebot merged 2 commits intomainfrom Jan 27, 2026
Merged
Conversation
4dea856 to
79c5f1c
Compare
Add unit tests to verify: - UnsupportedModelError includes guidance about provider/model format - LLMProvider logs deprecation warning for legacy model names - Legacy model names still work (non-breaking) - Provider/model format works without deprecation warning - UnsupportedAISDKModelProviderError for invalid providers Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates to inform users about the new provider/model format: 1. UnsupportedModelError now includes a note encouraging users to use the provider/model format (e.g., "openai/gpt-4o") instead of the legacy format (e.g., "gpt-4o") 2. Fixed the default case in LLMProvider switch to throw UnsupportedModelProviderError (for internal consistency issues) instead of UnsupportedModelError (which is for user-facing errors) This is a non-breaking change - legacy model names still work but users are now informed about the preferred format. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
79c5f1c to
ef92609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan