Skip to content

feat(sandminer): drop empty waterskins when humidify disabled #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmason0 merged 2 commits into from
Aug 29, 2025
Merged

feat(sandminer): drop empty waterskins when humidify disabled #1440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf929a
feat(sandminer): drop empty waterskins when humidify is disabled
Aug 29, 2025
ba18db4
refactor(sandminer): drop empty waterskins only when idle and drop all
Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...java/net/runelite/client/plugins/microbot/gabplugs/sandminer/GabulhasSandMinerScript.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ private void miningLoop(GabulhasSandMinerConfig config) {
sleep(100, 4000);
}
while (!Rs2Inventory.isFull() && super.isRunning()) {
// Drop empty waterskins if not using humidify (only when idle)
if (!config.useHumidify() && !Rs2Player.isAnimating()) {
dropEmptyWaterskins();
}

while (Rs2Player.hopIfPlayerDetected(1, 3000, 100) && super.isRunning()) {
sleepUntil(() -> Microbot.getClient().getGameState() == GameState.HOPPING);
sleepUntil(() -> Microbot.getClient().getGameState() == GameState.LOGGED_IN);
Expand Down Expand Up @@ -131,6 +136,12 @@ private void humidifyIfNeeded() {
}
}

private void dropEmptyWaterskins() {
while (Rs2Inventory.hasItem(ItemID.WATER_SKIN0)) {
Rs2Inventory.drop(ItemID.WATER_SKIN0);
}
}

private void deposit(GabulhasSandMinerConfig config) {
if (!config.turboMode()) Rs2Walker.walkTo(grinder);
GameObject sandstoneRock = Rs2GameObject.findObject(26199, grinder);
Expand Down