Frostyrc break + startup fixes#1461
Conversation
…uled, immediately stopping script when break is detected.
…rting if starting with degraded pouch.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthrough
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcPlugin.java(1 hunks)runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java(5 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-25T07:26:53.623Z
Learnt from: Voxsylvae
PR: chsami/Microbot#1415
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/pluginscheduler/SchedulerPlugin.java:2341-2366
Timestamp: 2025-08-25T07:26:53.623Z
Learning: In SchedulerPlugin.startLoginMonitoringThread(), do not gate startup on isBreakHandlerEnabled(); rely on isOnBreak() to suppress the monitor only when a break is actually active. This avoids blocking login monitoring whenever BreakHandler is merely enabled.
Applied to files:
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java
🧬 Code graph analysis (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java (2)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/inventory/Rs2Inventory.java (1)
Rs2Inventory(60-2244)runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/magic/Rs2Magic.java (1)
Rs2Magic(44-608)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (5)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcPlugin.java (1)
60-60: Version bump looks good.
Public version updated to v1.1.2 matches PR scope. No further changes in this file.runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java (4)
218-223: Good: unlock before honoring break state.
Clearing lock before returning on active/imminent break avoids deadlocking the BreakHandler.
488-491: Statue teleport block is fine.
Guarding against animation before interacting is reasonable; downstream checks gate progress.
743-747: LGTM: unlocking after crafting.
Releasing the lock at the end of crafting aligns with the break-pause semantics.
773-797: Teleport ordering/refill hook looks correct.
Prioritizing Ferox when refilling and triggeringhandleFeroxRunEnergy()immediately is consistent with the PR goals.
| if (shouldPauseForBreak()) return; | ||
| long startTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Break pause without unlocking can stall BreakHandler.
If a break becomes active mid-loop, returning early here won’t release the BreakHandler lock unless breakIn <= 0. If the lock was set to true in a prior step, BreakHandler may be blocked. Fix in shouldPauseForBreak() to always unlock on any pause condition. See suggested diff below.
🤖 Prompt for AI Agents
In
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java
around lines 104-105, returning early when shouldPauseForBreak() is true can
leave the BreakHandler lock held and stall the handler; update
shouldPauseForBreak() (or the caller) so that any pause path explicitly
releases/unlocks the BreakHandler before returning—e.g., ensure
BreakHandler.unlock() is invoked on every pause condition (use a finally or
explicit unlock before return) so the lock is never left set when pausing.
| private boolean shouldPauseForBreak() { | ||
| if (!plugin.isBreakHandlerEnabled()) { | ||
| return false; | ||
| } | ||
|
|
||
| if (BreakHandlerScript.isBreakActive()) { | ||
| return true; | ||
| } | ||
|
|
||
| if (BreakHandlerScript.breakIn <= 0) { | ||
| BreakHandlerScript.setLockState(false); | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Always clear BreakHandler lock when pausing.
When isBreakActive() is true you return without calling setLockState(false), potentially preventing BreakHandler from taking over. Unlock for both active and imminent breaks.
Apply:
private boolean shouldPauseForBreak() {
if (!plugin.isBreakHandlerEnabled()) {
return false;
}
- if (BreakHandlerScript.isBreakActive()) {
- return true;
- }
+ if (BreakHandlerScript.isBreakActive()) {
+ BreakHandlerScript.setLockState(false);
+ return true;
+ }
if (BreakHandlerScript.breakIn <= 0) {
BreakHandlerScript.setLockState(false);
return true;
}
return false;
}🤖 Prompt for AI Agents
In
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java
around lines 164 to 179, when BreakHandlerScript.isBreakActive() returns true
the method returns without clearing the BreakHandler lock; modify the method so
it calls BreakHandlerScript.setLockState(false) before returning true for both
the active-break branch and the breakIn <= 0 branch (i.e., ensure the lock is
released in both cases), keeping the existing checks and return values
otherwise.
| if (Rs2Inventory.hasDegradedPouch()) { | ||
| Rs2Magic.repairPouchesWithLunar(); | ||
| sleepGaussian(900, 200); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Repairing pouches while bank UI is open can fail; close and wait first.
Casting/contact dialogues often fail with bank open. Also, only early-return if repair succeeded; otherwise fall through to normal banking.
Apply:
- if (Rs2Inventory.hasDegradedPouch()) {
- Rs2Magic.repairPouchesWithLunar();
- sleepGaussian(900, 200);
- return;
- }
+ if (Rs2Inventory.hasDegradedPouch()) {
+ if (Rs2Bank.isOpen()) {
+ Rs2Bank.closeBank();
+ sleepUntil(() -> !Rs2Bank.isOpen(), 1200);
+ }
+ if (Rs2Magic.repairPouchesWithLunar()) {
+ sleepGaussian(900, 200);
+ return;
+ }
+ // If repair failed, continue with banking logic this tick.
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (Rs2Inventory.hasDegradedPouch()) { | |
| Rs2Magic.repairPouchesWithLunar(); | |
| sleepGaussian(900, 200); | |
| return; | |
| } | |
| if (Rs2Inventory.hasDegradedPouch()) { | |
| if (Rs2Bank.isOpen()) { | |
| Rs2Bank.closeBank(); | |
| sleepUntil(() -> !Rs2Bank.isOpen(), 1200); | |
| } | |
| if (Rs2Magic.repairPouchesWithLunar()) { | |
| sleepGaussian(900, 200); | |
| return; | |
| } | |
| // If repair failed, continue with banking logic this tick. | |
| } |
🤖 Prompt for AI Agents
In
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java
around lines 199-204, closing the bank UI and waiting before attempting to
repair pouches is required and the method should only early-return if the repair
actually succeeded; modify the block to first close the bank if it's open (and
wait until it's closed), sleep briefly to ensure dialogs can be opened, then
call Rs2Magic.repairPouchesWithLunar(); after the repair attempt, verify success
by checking that Rs2Inventory.hasDegradedPouch() is now false and only then
sleepGaussian(900, 200) and return; if the pouch still degrades, fall through to
normal banking logic so the rest of the method can handle it.
| if (Rs2Bank.isOpen()) { Rs2Bank.closeBank(); } | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure bank is fully closed before myth cape interactions.
Without a wait, item interactions can be flaky if the bank overlay lingers a tick.
Apply:
- if (Rs2Bank.isOpen()) { Rs2Bank.closeBank(); }
+ if (Rs2Bank.isOpen()) {
+ Rs2Bank.closeBank();
+ sleepUntil(() -> !Rs2Bank.isOpen(), 1200);
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (Rs2Bank.isOpen()) { Rs2Bank.closeBank(); } | |
| if (Rs2Bank.isOpen()) { | |
| Rs2Bank.closeBank(); | |
| sleepUntil(() -> !Rs2Bank.isOpen(), 1200); | |
| } |
🤖 Prompt for AI Agents
In
runelite-client/src/main/java/net/runelite/client/plugins/microbot/frosty/frostyrc/RcScript.java
around lines 480-481, the code closes the bank but does not wait for the bank
overlay to fully disappear, causing flaky item interactions; modify the logic to
close the bank and then wait until Rs2Bank.isOpen() returns false (or until a
short timeout, e.g., 500ms) before proceeding with myth cape interactions so the
overlay is fully gone and subsequent clicks are reliable.
2 participants
Uh oh!
There was an error while loading. Please reload this page.