Add worldhopping and gem bag to Fortis Gem Stall by heap-overfl0w · Pull Request #1482 · chsami/Microbot

heap-overfl0w · 2025-09-06T20:12:33Z

Added world hopping logic to Fortis Gem Stall due to long stall respawn times.
Added fuzzy gem bag support because I don't have an account to test this with. My implementation passes the eye test but will need actual testing.

2.0.0

…pawn times. - Added fuzzy gem bag support because I don't have an account to test this with. My implementation passes the eye test but will need actual testing.

coderabbitai · 2025-09-06T20:12:40Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

README: removed Quest Helper Integration (including Not Enough Runes and Shortest Path), related images/instructions, and Help and discussion (including Buy Me a Coffee). No new content added.
FortisGemStallThievingSpot: added early return on nearby player detection; added world-hopping and login-wait when stall is missing or lacks Steal-from action; implemented gem bag handling (check full, open/fill with uncut sapphire/emerald/ruby/diamond); updated banking to deposit specific uncut gems, empty gem bag, deposit all except gem bag and its open state, then close bank; introduced helper methods for gem detection and bag fullness; updated imports. No exported/public signature changes.

Possibly related PRs

Stop on no runes #1473: Modifies FortisGemStallThievingSpot; this PR further refines its thieving, banking, and gem-bag logic.
Add fortis gem stall #1472: Adds Fortis gem stall spot and mappings; this PR builds on it with hopping, login, and gem-bag management.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java (1)
112-116: Gem bag “full” check is inconsistent with handled gem types.

You deposit/fill only 4 uncut types, but the check requires 5 entries, so the bag may never be considered “completely full,” causing unnecessary Fill attempts.
-        return Rs2Gembag.getGemBagContents().size() == 5 &&
-                Rs2Gembag.getGemBagContents().stream().allMatch(g -> g.getQuantity() >= 60);
+        var contents = Rs2Gembag.getGemBagContents();
+        return contents.size() >= 4 && contents.stream().allMatch(g -> g.getQuantity() >= 60);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cdf8cc and 06d0851.

📒 Files selected for processing (2)

README.md (0 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java (2 hunks)

💤 Files with no reviewable changes (1)

README.md

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-25T15:51:39.272Z

Learnt from: runsonmypc
PR: chsami/Microbot#1417
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/AgilityScript.java:13-13
Timestamp: 2025-08-25T15:51:39.272Z
Learning: Both net.runelite.api.ItemID and net.runelite.api.gameval.ItemID are valid import paths in the RuneLite codebase. The microbot plugins consistently use net.runelite.api.ItemID as their established pattern.

Applied to files:

runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java

🧬 Code graph analysis (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java (3)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2GameObject.java (1)

Rs2GameObject (36-2002)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/inventory/Rs2Inventory.java (1)

Rs2Inventory (60-2244)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/player/Rs2Player.java (1)

Rs2Player (67-2070)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build

🔇 Additional comments (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java (1)

39-41: Verify hopIfPlayerDetected doesn’t include the local player.

If getPlayers includes self, amountOfPlayers=1 and time=0 will trigger perpetual hopping.

Would you confirm getPlayers excludes the local player? If not, filter the local player or increase amountOfPlayers to 2 for safety.

coderabbitai · 2025-09-06T20:17:19Z

...a/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java

+        if (!Rs2GameObject.hasAction(Rs2GameObject.convertToObjectComposition(stall), "Steal-from")) {
+            boolean started = Microbot.hopToWorld(Login.getRandomWorld(Rs2Player.isMember()));
+            if (started) {
+                Global.sleepUntil(Microbot::isLoggedIn, 15000);
+            }
            return;


⚠️ Potential issue

Fix wrong method arity for convertToObjectComposition (likely compile error).

convertToObjectComposition requires the ignoreImpostor boolean. Without it, this won’t compile.

- if (!Rs2GameObject.hasAction(Rs2GameObject.convertToObjectComposition(stall), "Steal-from")) { + if (!Rs2GameObject.hasAction(Rs2GameObject.convertToObjectComposition(stall, false), "Steal-from")) {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

if (!Rs2GameObject.hasAction(Rs2GameObject.convertToObjectComposition(stall), "Steal-from")) {

boolean started = Microbot.hopToWorld(Login.getRandomWorld(Rs2Player.isMember()));

if (started) {

Global.sleepUntil(Microbot::isLoggedIn, 15000);

}

return;

if (!Rs2GameObject.hasAction(

Rs2GameObject.convertToObjectComposition(stall, false), "Steal-from"))

{

boolean started = Microbot.hopToWorld(Login.getRandomWorld(Rs2Player.isMember()));

if (started) {

Global.sleepUntil(Microbot::isLoggedIn, 15000);

}

return;

}

🤖 Prompt for AI Agents

In runelite-client/src/main/java/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java around lines 52 to 57, the call to Rs2GameObject.convertToObjectComposition(stall) uses the wrong arity; update the call to include the required ignoreImpostor boolean parameter (e.g., convertToObjectComposition(stall, true)) so the method signature matches the API and the code compiles, keeping the rest of the logic unchanged.

…ragonstones, our gem bag will never be "completely full" (consisting of >= 60 gems of all 5 types) and could cause unnecessary fill attempts. Let's check the 4 types individually.

…to add-worldhopping-and-gem-bag

See1Duck

Seems just fine to me

See1Duck · 2025-09-06T20:32:21Z

...a/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java

+
+    private boolean isUncutGem(Rs2ItemModel item) {
+        String n = item.getName().toLowerCase();
+        return n.equals("uncut sapphire") ||


Just a suggestion, avoid using hardcoded names, you could instead check and match ItemID

About to fix this.

The actual Rs2GemBag suggests using lowercase naming is the way to go. Maybe we need to update it where possible to use ItemID. instead of "uncut ..."? I've fixed it anyway in the script.

should be updated to use ItemID or maybe an enum or constant in case the string name is important

...a/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java

SteffenCarlsen

One comment, otherwise LGTM.

...a/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java

chsami and others added 4 commits September 3, 2025 14:22

Merge pull request chsami#1465 from chsami/development

a5f4662

2.0.0

Update README.md

2239281

- Added world hopping logic to Fortis Gem Stall due to long stall res…

5ddaf5a

…pawn times. - Added fuzzy gem bag support because I don't have an account to test this with. My implementation passes the eye test but will need actual testing.

Merge branch 'chsami:main' into add-worldhopping-and-gem-bag

06d0851

coderabbitai bot reviewed Sep 6, 2025

View reviewed changes

heap-overfl0w added 2 commits September 6, 2025 15:25

Coderabbit made a good point... Because this stall doesn't give you d…

41bcd2e

…ragonstones, our gem bag will never be "completely full" (consisting of >= 60 gems of all 5 types) and could cause unnecessary fill attempts. Let's check the 4 types individually.

Merge remote-tracking branch 'origin/add-worldhopping-and-gem-bag' in…

61a4b25

…to add-worldhopping-and-gem-bag

See1Duck suggested changes Sep 6, 2025

View reviewed changes

Stick with ItemID.<name> usage

cf098c7

See1Duck approved these changes Sep 6, 2025

View reviewed changes

SteffenCarlsen reviewed Sep 7, 2025

View reviewed changes

...a/net/runelite/client/plugins/microbot/thieving/stalls/model/FortisGemStallThievingSpot.java Show resolved Hide resolved

chsami merged commit 21be467 into chsami:development Sep 8, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Add worldhopping and gem bag to Fortis Gem Stall#1482

Add worldhopping and gem bag to Fortis Gem Stall#1482
chsami merged 7 commits intochsami:developmentfrom
heap-overfl0w:add-worldhopping-and-gem-bag

heap-overfl0w commented Sep 6, 2025

Uh oh!

coderabbitai bot commented Sep 6, 2025 •

edited

Loading

Review skipped

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Sep 6, 2025

Uh oh!

See1Duck left a comment

Uh oh!

See1Duck Sep 6, 2025

Uh oh!

heap-overfl0w Sep 6, 2025

Uh oh!

heap-overfl0w Sep 6, 2025

Uh oh!

See1Duck Sep 6, 2025

Uh oh!

Uh oh!

SteffenCarlsen left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Comments

Conversation

heap-overfl0w commented Sep 6, 2025

Uh oh!

coderabbitai bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

See1Duck left a comment

Choose a reason for hiding this comment

Uh oh!

See1Duck Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

heap-overfl0w Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

heap-overfl0w Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

See1Duck Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SteffenCarlsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Sep 6, 2025 •

edited

Loading