Skip to content

Comments

Remove Runelite's AccountPlugin#1499

Merged
chsami merged 2 commits intochsami:developmentfrom
Bolado:feat/remove-accountplugin
Sep 10, 2025
Merged

Remove Runelite's AccountPlugin#1499
chsami merged 2 commits intochsami:developmentfrom
Bolado:feat/remove-accountplugin

Conversation

@Bolado
Copy link
Contributor

@Bolado Bolado commented Sep 9, 2025

Removing AccountPlugin prevents user overwriting Microbot session data into saved Runelite session data.

Github Copilot Summary

This pull request removes the AccountPlugin and makes minor improvements to the MicrobotPlugin code for clarity and maintainability. The most significant change is the complete removal of the account sync plugin, while the other changes involve minor documentation and import cleanups.

Plugin removal

  • Completely removes the AccountPlugin class, which handled syncing RuneLite config settings with a Google account and provided login/logout toolbar buttons. (runelite-client/src/main/java/net/runelite/client/plugins/account/AccountPlugin.java)

Code clarity and documentation improvements

  • Updates a Javadoc comment in MicrobotPlugin to clarify the source of container IDs by simplifying the reference to InventoryID.
  • Updates a parameter name in a Javadoc comment from overlayBounds to overlayBoundsCanvas for better clarity in MicrobotPlugin.

- Rename parameter for clarity in hasWidgetOverlapWithBounds method
- Delete AccountPlugin from plugins folder
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Walkthrough

This change removes the AccountPlugin.java file, eliminating the AccountPlugin public class and its login/logout toolbar buttons, async session login/logout handling, and session open/close event subscriptions. In MicrobotPlugin.java, getShopContainerIds now reflects InventoryID.class directly instead of net.runelite.api.gameval.InventoryID, and its Javadoc references InventoryID accordingly. The public method hasWidgetOverlapWithBounds renamed its parameter from overlayBounds to overlayBoundsCanvas, updating both the signature and Javadoc without altering internal logic.

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Remove Runelite's AccountPlugin” directly and succinctly captures the primary change of deleting the AccountPlugin class, matching the core intent of the pull request without extraneous detail.
Description Check ✅ Passed The description clearly outlines both the removal of the AccountPlugin and the minor MicrobotPlugin documentation updates, aligning with the detailed changes in the pull request.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa34241 and 5972240.

📒 Files selected for processing (2)
  • runelite-client/src/main/java/net/runelite/client/plugins/account/AccountPlugin.java (0 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java (2 hunks)
💤 Files with no reviewable changes (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/account/AccountPlugin.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (2)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java (2)

254-258: Javadoc link clarification looks good.

The reference to InventoryID is clearer and matches the actual usage.


261-289: Import-based switch to InventoryID.class is fine.

No functional change; resolves cleanly given the explicit net.runelite.api.gameval.InventoryID import.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 1ad9a37 into chsami:development Sep 10, 2025
2 checks passed
@Bolado Bolado deleted the feat/remove-accountplugin branch September 10, 2025 03:16
@coderabbitai coderabbitai bot mentioned this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants