Remove Runelite's AccountPlugin#1499
Conversation
- Rename parameter for clarity in hasWidgetOverlapWithBounds method - Delete AccountPlugin from plugins folder
WalkthroughThis change removes the AccountPlugin.java file, eliminating the AccountPlugin public class and its login/logout toolbar buttons, async session login/logout handling, and session open/close event subscriptions. In MicrobotPlugin.java, getShopContainerIds now reflects InventoryID.class directly instead of net.runelite.api.gameval.InventoryID, and its Javadoc references InventoryID accordingly. The public method hasWidgetOverlapWithBounds renamed its parameter from overlayBounds to overlayBoundsCanvas, updating both the signature and Javadoc without altering internal logic. Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removing AccountPlugin prevents user overwriting Microbot session data into saved Runelite session data.
Github Copilot Summary
This pull request removes the
AccountPluginand makes minor improvements to theMicrobotPlugincode for clarity and maintainability. The most significant change is the complete removal of the account sync plugin, while the other changes involve minor documentation and import cleanups.Plugin removal
AccountPluginclass, which handled syncing RuneLite config settings with a Google account and provided login/logout toolbar buttons. (runelite-client/src/main/java/net/runelite/client/plugins/account/AccountPlugin.java)Code clarity and documentation improvements
MicrobotPluginto clarify the source of container IDs by simplifying the reference toInventoryID.overlayBoundstooverlayBoundsCanvasfor better clarity inMicrobotPlugin.