Skip to content

Comments

Combathotkeys 1.7.4#1514

Closed
SamBunker wants to merge 2 commits intochsami:mainfrom
SamBunker:combathotkeys-1.7.4
Closed

Combathotkeys 1.7.4#1514
SamBunker wants to merge 2 commits intochsami:mainfrom
SamBunker:combathotkeys-1.7.4

Conversation

@SamBunker
Copy link
Contributor

Added offensive prayers hotkeys with dropdown menus for people to choose which offensive prayers for melee, range, and mage to use.

Added a max equipment delay setting with a default delay of 500 ms to randomize each equipped item. Originally, it seems each item equipped in the list of items had the same timing with little to no variation in timing.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • .run/Runelite.run.xml: Updates ALTERNATIVE_JRE_PATH to "temurin-11 (3)" and removes "-clean-jagex-launcher" from PROGRAM_PARAMETERS.
  • CombatHotkeysConfig: Adds an Offensive Prayers section with melee/ranged/magic hotkeys and enums mapping to Rs2PrayerEnum; introduces Gear Equip Settings with maxDelay (ms) and shifts gearSetup section positions; imports Rs2PrayerEnum.
  • CombatHotkeysPlugin: Adds handlers for new offensive prayer hotkeys using Rs2Prayer.toggle; changes equipGear to an instance method and inserts a random sleep between equips using Rs2Random.between(0, config.maxDelay()) with sleep import.

Possibly related PRs

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4cf2c2 and 793619d.

📒 Files selected for processing (3)
  • .run/Runelite.run.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/combathotkeys/CombatHotkeysConfig.java (8 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/combathotkeys/CombatHotkeysPlugin.java (4 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SamBunker
Copy link
Contributor Author

Wait, Update Runelite.run.xml should not be in there.

@SamBunker SamBunker closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant