Skip to content

Comments

fix: update varbit and varplayer checks to use correct Microbot methods#1532

Merged
chsami merged 1 commit intomainfrom
development
Sep 21, 2025
Merged

fix: update varbit and varplayer checks to use correct Microbot methods#1532
chsami merged 1 commit intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Sep 21, 2025

bug fixes

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • Updated runelite-client/pom.xml to set microbot.version from 2.0.10 to 2.0.11.
  • Refactored PathfinderConfig to replace Client-based varbit/varp reads with Microbot static accessors:
    • Microbot.getClient().getVarbitValue(...) -> Microbot.getVarbitValue(...)
    • Microbot.getClient().getVarpValue(...) -> Microbot.getVarbitPlayerValue(...)
    • Applied across restriction checks and precondition evaluations.
  • Updated Rs2Player.isMember() to use Microbot.getVarbitPlayerValue(VarPlayerID.ACCOUNT_CREDIT) instead of Microbot.getClient().getVarpValue(...).
  • No changes to public method signatures or exported entities.
✨ Finishing touches
  • 📝 Generate Docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b04a4f4 and 52e7696.

📒 Files selected for processing (3)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/PathfinderConfig.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/player/Rs2Player.java (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit a74a429 into main Sep 21, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant