Skip to content

Comments

feat: show startup crash details on splash screen#1570

Merged
chsami merged 3 commits intodevelopmentfrom
codex/add-crash-splash-screen-with-stacktrace
Oct 16, 2025
Merged

feat: show startup crash details on splash screen#1570
chsami merged 3 commits intodevelopmentfrom
codex/add-crash-splash-screen-with-stacktrace

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Oct 16, 2025

Summary

  • add a CrashReportFormatter helper and expose crash details via FatalErrorDialog copy buttons
  • surface startup failures on the splash screen with an error card and clipboard-friendly copy action

Testing

  • ⚠️ mvn -pl runelite-client -DskipTests compile (fails: unable to download com.google.inject:guice-bom:4.1.0 due to HTTP 403)

https://chatgpt.com/codex/tasks/task_e_68f06d7cf3bc83289fcd48cebf149198

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change adds centralized crash formatting via CrashReportFormatter and integrates it into startup error handling for RuneLite and RuneLiteDebug. On exceptions during startup, the code now generates a crash summary and details, shows them on the SplashScreen using a new SplashScreen.showError API if the splash is active, or via a FatalErrorDialog otherwise. SplashScreen gains an error card with copy-to-clipboard support and avoids progress updates while showing errors. FatalErrorDialog now supports dynamic content updates and copy buttons. SplashScreen.stop is skipped when startup fails. No public signatures were removed.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat: show startup crash details on splash screen" directly aligns with the primary objective and main change in the changeset. The title is concise, clear, and accurately summarizes the core functionality being added: displaying startup crash details on the splash screen. The changes across RuneLite.java, RuneLiteDebug.java, SplashScreen.java, FatalErrorDialog.java, and the new CrashReportFormatter.java all work cohesively to implement this feature, making the title both specific and representative of the changeset.
Description Check ✅ Passed The pull request description is clearly related to the changeset and provides meaningful information about the changes. It accurately describes the two main components: adding a CrashReportFormatter helper utility and surfacing startup failures on the splash screen with copy functionality. Each point in the description is directly reflected in the raw_summary, from the new utility class to the FatalErrorDialog enhancements and the SplashScreen.showError() API addition.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit ff25a14 into development Oct 16, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 16, 2025
@chsami chsami deleted the codex/add-crash-splash-screen-with-stacktrace branch November 16, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant