Skip to content

Comments

handleInventoryTeleports with specific teleport actions#1571

Merged
chsami merged 3 commits intochsami:developmentfrom
Krulvis:development
Oct 16, 2025
Merged

handleInventoryTeleports with specific teleport actions#1571
chsami merged 3 commits intochsami:developmentfrom
Krulvis:development

Conversation

@Krulvis
Copy link
Contributor

@Krulvis Krulvis commented Oct 16, 2025

Make sure every item that does not use a generic keyword to teleport has the proper action as part of the Display Info

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

This pull request modifies the Rs2Walker utility class to refine teleportation handling logic. The changes reduce the generic teleport keyword fallback list in handleInventoryTeleports to a smaller set of actions. A variable is renamed from hasMultipleDestination to hasParsableDestination with corresponding logic updates for destination extraction and normalization to lowercase. The conditional flow is updated to use the new variable-based logic. Additionally, a docstring reference to xeric talisman is removed from interactWithAdventureLog for simplification.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately highlights that the handleInventoryTeleports method now uses specific teleport actions rather than generic fallbacks, which directly reflects the core changes in the pull request by focusing on the key update in teleport handling logic.
Description Check ✅ Passed The description clearly states that the update ensures items without generic teleport keywords use their proper actions in Display Info, which directly corresponds to the logic refinements and keyword scope reductions implemented in handleInventoryTeleports.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfcb715 and d8a6287.

⛔ Files ignored due to path filters (1)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_items.tsv is excluded by !**/*.tsv
📒 Files selected for processing (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (3 hunks)
🔇 Additional comments (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (1)

1865-1867: The action-matching methods already implement case-insensitive logic: getAction() expects a lowercase parameter, while getIndexOfSubAction() and getActionFromList() both lowercase both operands before comparison. The addition of .toLowerCase() to destination extraction is consistent with these expectations.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 34ddf36 into chsami:development Oct 16, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants