2.0.29

[chsami]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR centralizes login and profile management by introducing a new LoginManager utility class and systematically replacing direct usages of the deprecated Login class throughout the codebase. Key changes include: removing static login-tracking fields (loggedIn, loginTime) from Microbot, updating ConfigManager and ProfileManager to route profile switching through LoginManager, migrating login orchestration in scripts (AutoLoginScript, BreakHandlerScript, SchedulerPlugin) and utilities (Rs2Bank, Rs2GrandExchange, Rs2WorldUtil) to use centralized login APIs, refactoring login-state checks from field access to method calls (isLoggedIn()), marking Login as deprecated, and incrementing the microbot version to 2.0.29.

Possibly related PRs

• 2.0.12 #1533: Earlier refactor that introduced the Microbot.loggedIn field and login-state tracking logic that is now being centralized through LoginManager in this PR.
• fix: prevent multiple Login instances in break handler #1524: Modifies break handler login flow and state transitions in BreakHandlerScript, which this PR also updates to use LoginManager for login orchestration.
• 2.0.8 #1528: Updates Microbot runtime and cache behavior including modifications to Script.run() and cache gating, which interact with the login-state changes in this PR.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3285b1 and e2a041e.

⛔ Files ignored due to path filters (1)

• runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_items.tsv is excluded by !**/*.tsv

📒 Files selected for processing (27)

• runelite-client/pom.xml (1 hunks)
• runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/config/ProfileManager.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/Microbot.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/Script.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/accountselector/AutoLoginScript.java (5 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/breakhandler/BreakHandlerScript.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/pluginscheduler/SchedulerPlugin.java (4 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/pluginscheduler/tasks/requirements/requirement/shop/ShopRequirement.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/pluginscheduler/ui/util/SchedulerUIUtils.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/ui/MicrobotProfilePanel.java (4 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java (4 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/Rs2CacheManager.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/strategy/entity/GroundItemUpdateStrategy.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/strategy/entity/NpcUpdateStrategy.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/strategy/entity/ObjectUpdateStrategy.java (4 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/discord/Rs2Discord.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/BankJagexPopupEvent.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/WelcomeScreenEvent.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/grandexchange/Rs2GrandExchange.java (2 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/keyboard/Rs2Keyboard.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/player/Rs2Player.java (3 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/Login.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/LoginManager.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/world/Rs2WorldUtil.java (9 hunks)
• runelite-jshell/src/main/resources/net/runelite/jshell/prelude.jsh (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}