Skip to content

Comments

refactor(auth): remove lastLogoutTimestamp from markLoggedOut method#1580

Merged
chsami merged 1 commit intomainfrom
development
Oct 20, 2025
Merged

refactor(auth): remove lastLogoutTimestamp from markLoggedOut method#1580
chsami merged 1 commit intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Oct 20, 2025

No description provided.

@chsami chsami merged commit dd43e4f into main Oct 20, 2025
2 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A modification to the markLoggedOut() method in LoginManager.java removes the assignment to lastLogoutTimestamp. The method continues to clear the LOGIN_ATTEMPT_ACTIVE flag but no longer records when the logout occurred.

Inconsistent Logic

There appears to be a logical inconsistency: the method is named markLoggedOut() which semantically implies recording a logout event, yet it no longer updates lastLogoutTimestamp. This disconnect between the method's purpose (marking a logout) and its implementation (no longer tracking when the logout happened) may indicate unintended behavior.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d0eefa and 3688924.

📒 Files selected for processing (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/LoginManager.java (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot mentioned this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant