fix(WebWalker): fix action matching for equipment items#1586
fix(WebWalker): fix action matching for equipment items#1586chsami merged 1 commit intochsami:developmentfrom
Conversation
Inventory items are already using a contains check. This allows the bug fix form !1574 to also work with equipped items.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes action matching for equipment items in the WebWalker by changing from exact string matching to substring matching. This aligns the behavior with inventory items and enables partial action matching for equipped items.
Key Changes:
- Modified equipment action matching to use case-insensitive substring matching instead of exact matching
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WalkthroughA modification to the Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)runelite-client/src/main/java/net/runelite/client/plugins/microbot/**/*.java📄 CodeRabbit inference engine (AGENTS.md)
Files:
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/**/*.java📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.java📄 CodeRabbit inference engine (AGENTS.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Inventory items are already using a contains check.
This allows the bug fix from #1574 to also work with equipped items.
Improvements to equipment action matching:
invokeMenuso that it now checks if the equipment action contains the input string (case-insensitive), rather than requiring an exact match. This allows for partial matches.