Skip to content

Comments

fix(Rs2Settings): update menu entry parameters for toggle action#1599

Merged
chsami merged 1 commit intochsami:developmentfrom
Bolado:fix/rs2settings
Nov 10, 2025
Merged

fix(Rs2Settings): update menu entry parameters for toggle action#1599
chsami merged 1 commit intochsami:developmentfrom
Bolado:fix/rs2settings

Conversation

@Bolado
Copy link
Contributor

@Bolado Bolado commented Nov 10, 2025

Fix BlockingEvent loop when trying to disable world switching warning.

  • Adjust getParam0 value for toggle action in menu entry
  • Update getParam1 value for consistency in menu entry

- Adjust getParam0 value for toggle action in menu entry
- Update getParam1 value for consistency in menu entry
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

This change updates numeric parameters in menu entry constructions within the settings utility class. Specifically, it modifies two CC_OP invocation parameters: the first parameter in enableDropShiftSetting is incremented by one (from 8781843 to 8781844), and the first parameter in disableWorldSwitcherConfirmation is incremented by one (from 34 to 35). The surrounding control flow and logic remain unchanged.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating menu entry parameters for toggle action in Rs2Settings.
Description check ✅ Passed The pull request description accurately describes the changes made: adjusting getParam0 and getParam1 values in menu entry constructions for toggle actions, which aligns with the code changes.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 3732aaa into chsami:development Nov 10, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants