Skip to content

Comments

Add config-driven prayer hotkey selector#1604

Closed
chsami wants to merge 1 commit intomainfrom
codex/add-pray-melee-icon-to-inventory-f5kat8
Closed

Add config-driven prayer hotkey selector#1604
chsami wants to merge 1 commit intomainfrom
codex/add-pray-melee-icon-to-inventory-f5kat8

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Nov 11, 2025

Summary

  • add a ConfigButton type to the configuration UI so plugin configs can expose clickable actions
  • expose prayer hotkey slot selection through Microbot config with a button that opens the chatbox selector interface on demand
  • swap the always-on PrayerHotkeyUi for a toggleable PrayerHotkeySelector and reload assignments whenever prayer hotkey config values change

Testing

  • mvn -pl runelite-client -am -DskipTests package (fails: unable to download com.google.inject:guice-bom:4.1.0 due to HTTP 403)

Codex Task

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR introduces a prayer hotkey system for the Microbot plugin alongside core infrastructure changes. It adds a new ConfigButton class to support actionable buttons in plugin configuration panels, with corresponding support in ConfigManager and ConfigPanel for rendering and handling these buttons. The PR extends MicrobotConfig with prayer hotkey configuration options and slots, and integrates multiple new components: PrayerHotkeyAssignments for slot persistence, PrayerHotkeyOption enum for prayer mappings, PrayerHotkeyOverlay for on-screen slot display, PrayerHotkeySelector for interactive configuration UI, and PrayerHotkeyConfigAccess for action routing. MicrobotPlugin is updated to instantiate and manage these new components during its lifecycle.

Possibly related PRs

  • Refactor Rs2Prayer #1463 — Refactors Rs2Prayer API which is directly invoked by the new PrayerHotkeyOverlay component for prayer toggling functionality.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c67b88e and 6f03e66.

📒 Files selected for processing (10)
  • runelite-client/src/main/java/net/runelite/client/config/ConfigButton.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/config/ConfigPanel.java (5 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotConfig.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java (6 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/PrayerHotkeyAssignments.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/PrayerHotkeyConfigAccess.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/PrayerHotkeyOption.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/PrayerHotkeyOverlay.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/PrayerHotkeySelector.java (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami closed this Nov 11, 2025
@chsami chsami deleted the codex/add-pray-melee-icon-to-inventory-f5kat8 branch November 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant