Skip to content

Comments

Update latest runelite#1627

Merged
chsami merged 15 commits intomainfrom
development
Dec 10, 2025
Merged

Update latest runelite#1627
chsami merged 15 commits intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Dec 10, 2025

No description provided.

@chsami chsami merged commit 2ed7386 into main Dec 10, 2025
2 of 3 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates the parent Maven version from 1.12.7 to 1.12.8 across multiple modules. It expands game value constants in the runelite-api layer, adding identifiers for items, NPCs, objects, and animations, primarily supporting a Christmas 2025 event theme. The fairyring plugin's auto-open behavior is removed and its search logic is refactored. A cryptic clue solution is corrected, and a new hot-cold clue location is added. The microbot LoginManager gains explicit game state tracking methods, and MicrobotPlugin updates its login state detection logic. GPU rendering and motherlode mining plugin behaviors are refined.

Possibly related PRs

  • 2.0.38 #1595: Modifies the same generated game-value constant files (ItemID, NpcID, ObjectID, etc.) and bumps parent POM versions in parallel.
  • tutorial island fix #1577: Modifies microbot LoginManager class to change its public API around game and login state handling.
  • 2.0.4 #1502: Modifies MicrobotPlugin in runelite-client to update lifecycle and login-state handling logic.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc84b7d and d65cfb4.

📒 Files selected for processing (33)
  • cache/pom.xml (1 hunks)
  • pom.xml (1 hunks)
  • runelite-api/pom.xml (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/ItemID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/NpcID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/NullItemID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/NullNpcID.java (3 hunks)
  • runelite-api/src/main/java/net/runelite/api/NullObjectID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/ObjectID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/ScriptID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/AnimationID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/DBTableID.java (2 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/ItemID.java (2 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/NpcID.java (5 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/VarClientID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/VarPlayerID.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/gameval/VarbitID.java (2 hunks)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/clues/CrypticClue.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/clues/hotcold/HotColdLocation.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/fairyring/FairyRingConfig.java (0 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/fairyring/FairyRingPlugin.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/gpu/GpuPlugin.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/security/LoginManager.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/motherlode/MotherlodePlugin.java (1 hunks)
  • runelite-client/src/main/scripts/fairyrings_sort_update.hash (1 hunks)
  • runelite-client/src/main/scripts/fairyrings_sort_update.rs2asm (18 hunks)
  • runelite-client/src/test/java/net/runelite/client/plugins/motherlode/MotherlodePluginTest.java (2 hunks)
  • runelite-jshell/pom.xml (1 hunks)
  • runelite-maven-plugin/pom.xml (1 hunks)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.40.0)
runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/NpcID.java
runelite-api/src/main/java/net/runelite/api/gameval/AnimationID.java
  • 9 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants