Skip to content

Comments

Added 60 Mining requirement for entering mining guild#1649

Merged
chsami merged 4 commits intochsami:developmentfrom
port-port:fix/walkerMiningGuildReqs
Jan 8, 2026
Merged

Added 60 Mining requirement for entering mining guild#1649
chsami merged 4 commits intochsami:developmentfrom
port-port:fix/walkerMiningGuildReqs

Conversation

@port-port
Copy link
Contributor

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Walkthrough

The change adds a single entry to the Exclusion enum in the CollisionMapDumper class. Specifically, it adds MINING_GUILD_DOOR_30364 with object ID 30364, which marks this object as an exclusion with blocked tile behavior. The modification is purely additive with no changes to existing logic or public API signatures.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to add a 60 Mining requirement, but the code change only adds an exclusion entry for a door object. The title does not reflect the actual implementation. Clarify whether the actual change is adding a collision map exclusion for a mining guild door, or if additional requirement-checking code is missing from this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description references using a collision map from archive.openrs2.org, which aligns with the code change adding a collision map exclusion entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d2165b and a05f2ea.

⛔ Files ignored due to path filters (2)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/collision-map.zip is excluded by !**/*.zip
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/transports.tsv is excluded by !**/*.tsv
📒 Files selected for processing (1)
  • cache/src/main/java/net/runelite/cache/CollisionMapDumper.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 7e8e836 into chsami:development Jan 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants