Skip to content

feat: add new bank locations with sailing requirements #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsami merged 2 commits into from
Feb 1, 2026
Merged

feat: add new bank locations with sailing requirements #1670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6d4cf
feat: add new bank locations with sailing requirements
irkedMATT Jan 31, 2026
e904697
Fix sailing level requirement for DEEPFIN_MINE_EAST
irkedMATT Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...ient/src/main/java/net/runelite/client/plugins/microbot/util/bank/enums/BankLocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public enum BankLocation {
CRAFTING_GUILD(new WorldPoint(2936, 3281, 0), true),
DARKFROST(new WorldPoint(1527, 3292, 0), true),
DARKMEYER(new WorldPoint(3604, 3366, 0), true),
DEEPFIN_POINT(new WorldPoint(1935, 2755,0), true),
DEEPFIN_MINE_MID(new WorldPoint(2011, 9186,0), true),
DEEPFIN_MINE_EAST(new WorldPoint(2094, 9197,0), true),
DORGESH_KAAN_BANK(new WorldPoint(2702, 5350, 0), true),
DRAYNOR_VILLAGE(new WorldPoint(3093, 3245, 0), false),
DUEL_ARENA(new WorldPoint(3381, 3268, 0), true),
Expand Down Expand Up @@ -98,7 +101,8 @@ public enum BankLocation {
SHILO_VILLAGE(new WorldPoint(2852, 2954, 0), true),
SOPHANEM(new WorldPoint(2799, 5169, 0), true),
SULPHUR_MINE(new WorldPoint(1453, 3858, 0), true),
TAL_TEKLAN(new WorldPoint(1243, 3121, 0), true),
SUNBLEAK_ISLAND(new WorldPoint(2195, 2314, 0), true),
TAL_TEKLAN(new WorldPoint(1243, 3121, 0), true),
TREE_GNOME_STRONGHOLD_NIEVE(new WorldPoint(2445, 3424, 1), true),
TZHAAR(new WorldPoint(2446, 5178, 0), true),
VARLAMORE_EAST(new WorldPoint(1780, 3094, 0), true),
Expand Down Expand Up @@ -259,6 +263,18 @@ public boolean hasRequirements() {
case PRIFDDINAS_SOUTH:
// Requires Song of the elves to be completed
return Rs2Player.getQuestState(Quest.SONG_OF_THE_ELVES) == QuestState.FINISHED;
case SUNBLEAK_ISLAND:
// Requires sailing level 72
return Rs2Player.getSkillRequirement(Skill.SAILING, 72, false);
case DEEPFIN_POINT:
// Requires sailing level 67
return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
case DEEPFIN_MINE_MID:
// Requires sailing level 67 + Bank to be made
return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
case DEEPFIN_MINE_EAST:
// Requires sailing level 67 + Bank to be made
return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
Comment on lines 275 to 277
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Level mismatch: comment says 68, code checks 67.

The comment states the requirement is sailing level 68, but the code checks for level 67. The PR objectives also indicate this location should require level 68.

Proposed fix 
 case DEEPFIN_MINE_EAST:
     // Requires sailing level 68 + Bank to be made
-    return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
+    return Rs2Player.getSkillRequirement(Skill.SAILING, 68, false);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
case DEEPFIN_MINE_EAST:
// Requires sailing level 68 + Bank to be made
return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
case DEEPFIN_MINE_EAST:
// Requires sailing level 68 + Bank to be made
return Rs2Player.getSkillRequirement(Skill.SAILING, 68, false);
🤖 Prompt for AI Agents 
In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/enums/BankLocation.java`
around lines 275 - 277, The DEEPFIN_MINE_EAST case in the BankLocation enum has
a mismatch: the comment and PR require Sailing level 68 but the code calls
Rs2Player.getSkillRequirement(Skill.SAILING, 67, false); update that call to use
68 and align the inline comment to "Requires sailing level 68 + Bank to be made"
so both code and comment reflect level 68.

default:
return true;
}
Expand Down