Delay modeline evaluation by moving plugin to after directory #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin evaluates the modeline during the `autocmd BufRead` event, which occurs before the modeline would normally be evaluated and, more importantly, before `:filetype detect`. This causes a filetype set in a modeline (e.g. `// vim: set ft=foo :`) not to work in cases that filetype is set in `~/.vim/filetype.vim` or a `ftdetect` script from a package. This commit fixes the issue by moving the script to the package `after` directory which causes `autocmd BufRead` to be executed after `:filetype detect` as it would be if this plugin were not installed. Fixes: ciaranm#20 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
ypcrts
added a commit
to ypcrts/securemodelines
that referenced
this pull request
Dec 23, 2019
alexghergh
added a commit
to alexghergh/securemodelines
that referenced
this pull request
Sep 14, 2020
As per [this](ciaranm#26) pull request. Credit to @kevinoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin evaluates the modeline during the
autocmd BufReadevent, which occurs before the modeline would normally be evaluated and, more importantly, before:filetype detect. This causes a filetype set in a modeline (e.g.// vim: set ft=foo :) not to work in cases that filetypeis set in
~/.vim/filetype.vimor aftdetectscript from a package.This commit fixes the issue by moving the plugin to the package
afterdirectory which causesautocmd BufReadto be executed after:filetype detectas it would be if this plugin were not installed, which makes filetype (and any other settings) from the modeline override settings fromftdetectas they normally would.Fixes: #20