Skip to content

Activate test-app lint in CI #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 2 commits into from
Oct 11, 2025
Merged

Activate test-app lint in CI #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7413759
Activate test-app lint
mkszepp Oct 11, 2025
7ec2ee9
Add missing component registration
mkszepp Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- run: pnpm i -f # re-sync injected deps

- name: Lint
run: pnpm --filter ember-basic-dropdown lint
run: pnpm --filter ember-basic-dropdown --filter test-app lint

test:
name: "Tests"
Expand Down
8 changes: 7 additions & 1 deletion test-app/app/components/shadow-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { getOwner } from '@ember/owner';
// @ts-expect-error Public property 'isFastBoot' of exported class
const isFastBoot = typeof FastBoot !== 'undefined';

export default class ShadowRootComponent extends Component<{
export default class ShadowRoot extends Component<{
Element: HTMLDivElement;
Blocks: { default: [] };
}> {
Expand Down Expand Up @@ -39,3 +39,9 @@ export default class ShadowRootComponent extends Component<{
return [...document.head.querySelectorAll('link')].map((link) => link.href);
}
}

declare module '@glint/environment-ember-loose/registry' {
export default interface Registry {
ShadowRoot: typeof ShadowRoot;
}
}
4 changes: 2 additions & 2 deletions test-app/app/components/shadow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import { modifier } from 'ember-modifier';

export default class ShadowComponent extends Component<{
export default class Shadow extends Component<{
Element: HTMLDivElement;
Blocks: { default: [] };
}> {
Expand All @@ -28,6 +28,6 @@ export default class ShadowComponent extends Component<{

declare module '@glint/environment-ember-loose/registry' {
export default interface Registry {
Shadow: typeof ShadowComponent;
Shadow: typeof Shadow;
}
}