Skip to content

Conversation

@mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Dec 12, 2025

To achieve full compatibility with template typing (Glint v2), it was necessary to move the @htmlTag property from the Trigger component to the main component, now exposed as @triggerHtmlTag.

If you are using <BasicDropdownTrigger @htmlTag="button">, no changes are required.

However, if you previously used the trigger like this:

<BasicDropdown as |dd|>
  <dd.Trigger @htmlTag="button">Click me!</dd.Trigger>
  <dd.Content>
    Content
  </dd.Content>
</BasicDropdown>

you must update it to:

<BasicDropdown @triggerHtmlTag="button" as |dd|>
  <dd.Trigger>Click me!</dd.Trigger>
  <dd.Content>
    Content
  </dd.Content>
</BasicDropdown>

This issue comes up, while moving to glint v2 (#1032). The typing will be improved in glint v2 branch

Note: Passing @htmlTag directly to the trigger still works at runtime, but it will produce a typing error.

@mkszepp mkszepp changed the title Add @triggerHtmlTag and remove @htmlTag from yielded trigger component Add @triggerHtmlTag on <BasicDropdown> and remove @htmlTag option from yielded trigger component (fix glint v2 issue) Dec 12, 2025
@mkszepp mkszepp mentioned this pull request Dec 12, 2025
17 tasks
@mkszepp mkszepp merged commit 8d1b4c1 into master Dec 12, 2025
19 checks passed
@mkszepp mkszepp deleted the add-property-triggerHtmlTag branch December 12, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants