Add @triggerHtmlTag on <BasicDropdown> and remove @htmlTag option from yielded trigger component (fix glint v2 issue)
#1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve full compatibility with template typing (Glint v2), it was necessary to move the
@htmlTagproperty from theTriggercomponent to the main component, now exposed as@triggerHtmlTag.If you are using
<BasicDropdownTrigger @htmlTag="button">, no changes are required.However, if you previously used the trigger like this:
you must update it to:
This issue comes up, while moving to glint v2 (#1032). The typing will be improved in glint v2 branch
Note: Passing
@htmlTagdirectly to the trigger still works at runtime, but it will produce a typing error.