Skip to content

Fixes the dropdown being incorrectly positioned when the body is position:: relative #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cibernox merged 1 commit into from
Jul 27, 2017
Merged

Fixes the dropdown being incorrectly positioned when the body is position:: relative #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion addon/utils/calculate-position.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,17 @@ export function calculateWormholedPosition(trigger, content, destination, { hori
}

// Calculate vertical position
let triggerTopWithScroll = triggerTop + scroll.top;
let triggerTopWithScroll = triggerTop;

/**
* Fixes bug where the dropdown always stays on the same position on the screen when
* the <body> is relatively positioned
*/
let isBodyPositionRelative = window.getComputedStyle(document.body).getPropertyValue('position') === 'relative';
if (!isBodyPositionRelative) {
triggerTopWithScroll += scroll.top;
}

if (verticalPosition === 'above') {
style.top = triggerTopWithScroll - dropdownHeight;
} else if (verticalPosition === 'below') {
Expand Down