Skip to content

Fix removing event listener for shadow root element #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkszepp merged 2 commits into from
Jun 4, 2025
Merged

Fix removing event listener for shadow root element #973

mkszepp merged 2 commits into from
Jun 4, 2025

Conversation

@mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Jun 4, 2025 •
edited
Loading

The event on shadowRoot element was never removed correctly...

this is the fix for reported bug #965...

repro

* click on trigger -> it opens

* click on something inside dropdown -> it stays open

* click on trigger 2d time-> it opens

* click on something inside dropdown -> it does NOT stay open

@mkszepp mkszepp added the bug label Jun 4, 2025
@mkszepp mkszepp mentioned this pull request Jun 4, 2025
Closed
@mkszepp mkszepp merged commit 82f3cec into master Jun 4, 2025
22 checks passed
@mkszepp mkszepp deleted the fix-shadow-root-eventlistener-removing branch June 4, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkszepp