Fix wrong behavior on s390x#91
Merged
Merged
Conversation
lmb
suggested changes
Apr 30, 2020
Contributor
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Thank you for contributing! I left some nits, I'd appreciate if you could look into them. Other than that I'm happy to merge the PR.
This was referenced May 4, 2020
Strictly speaking, bitfield order is defined by a respective arch ABI, however, in practice it always the same as byte order, and LLVM already makes use of this correlation, therefore do the same in here. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Contributor
|
Your proposals sound sane, looking forward to your update! |
Contributor
Author
|
I actually pushed one a few days back (3db7828) :-) Could you have a look please? |
lmb
approved these changes
May 7, 2020
Contributor
|
Oh boy, sorry about that! I missed the notification somehow. Thanks for working on this! |
alicefr
pushed a commit
to alicefr/runc
that referenced
this pull request
May 8, 2020
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
alicefr
pushed a commit
to alicefr/runc
that referenced
this pull request
May 8, 2020
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
alicefr
pushed a commit
to alicefr/runc
that referenced
this pull request
May 8, 2020
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86