Skip to content

fix: use tauri plugin dialog + fs to save a file#2814

Open
weareoutman wants to merge 2 commits intocinnyapp:devfrom
weareoutman:fix-file-save
Open

fix: use tauri plugin dialog + fs to save a file#2814
weareoutman wants to merge 2 commits intocinnyapp:devfrom
weareoutman:fix-file-save

Conversation

@weareoutman
Copy link
Copy Markdown

Description

Download are not working in latest cinny-desktop. This PR fixed it by using tauri plugin dialog + fs to save files.

Fixes #456 along with cinnyapp/cinny-desktop#562.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Comment on lines +14 to +17
const filePath = await save({
defaultPath: fileName,
filters: [{ name: 'File', extensions: [getExt(fileName)] }],
});
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Mac:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection lost - can't download

1 participant