feat: Custom background gradient support #2855
feat: Custom background gradient support #2855LilyLavenderPony wants to merge 11 commits intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
…e initial value is zero
325c033 to
c694c14
Compare
|
So adding a separate div on top isn't really the same thing as changing the background. This is especially apparent in the second image, where the gradient visibly tints all icons and text. Also, if we're going to start adding theme options, then "Appearance" should be its own settings tab instead of dominating General. |
You are right, this is a good point.
That is true. I chose this approach because modifying the actual background would require changes that could conflict with this PR, which is currently reworking the styling. So I went with a more isolated solution for now. However, I agree that the tinting of icons and text is unexpected behaviour for users and results in poor UX. It may be better to revisit or rework this PR once the CSS changes in Cinny have stabilized. Thanks to you and @kfiven for the feedback, and for moving this PR to draft. |
Description
This PR introduces a customizable background gradient feature, allowing users to define up to five colors, gradient angle, transparency and the option to apply the gradient on background elements only or the whole screen.
The gradient is applied on top of existing themes rather than introducing new theme variants, enabling lightweight visual customization without affecting the core theming system.
Examples using the Silver and Butter themes are shown below:
Implementation
Design considerations
This proposal builds on the discussion in #357 with some differences:
How to test
Tested on: