Building on Ubuntu 20.04 LTS / cloud-init parameter#68
Open
clebergnu wants to merge 3 commits intocirros-dev:mainfrom
Open
Building on Ubuntu 20.04 LTS / cloud-init parameter#68clebergnu wants to merge 3 commits intocirros-dev:mainfrom
clebergnu wants to merge 3 commits intocirros-dev:mainfrom
Conversation
There are parameters and variables and mentions about "output_d", "output_dir", "output dir" and "data dir", but they refer to the same thing. Let's use a single name across them all to improve the user experience and code readability. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Both 18.04 LTS and 20.04 LTS are equally capable of building cirros, so let's document this fact. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Some minimal systems (including the official container images) won't have those necessary packages installed. Let's add them to the system to allow for a successful build. Signed-off-by: Cleber Rosa <crosa@redhat.com>
hrw
requested changes
Aug 24, 2022
Collaborator
hrw
left a comment
hrw
left a comment
There was a problem hiding this comment.
Would be nice to get it updated.
| done | ||
|
|
||
| [ $# -eq 2 ] || bad_Usage "must provide mode and output dir" | ||
| [ $# -eq 2 ] || bad_Usage "must provide mode and output_dir" |
| done | ||
|
|
||
| [ $# -eq 2 ] || bad_Usage "must provide mode and data dir" | ||
| [ $# -eq 2 ] || bad_Usage "must provide mode and output_dir" |
Collaborator
There was a problem hiding this comment.
similar here (with s/data/output/)
| done | ||
|
|
||
| [ $# -eq 2 ] || bad_Usage "must provide mode and output dir" | ||
| [ $# -eq 2 ] || bad_Usage "must provide mode and output_dir" |
| # Build instructions | ||
|
|
||
| The following works on Ubuntu 18.04 LTS, running on x86_64. Native building for other architectures is not recommended. Support for building under other distributions is limited and not tested. | ||
| The following works on Ubuntu 18.04 LTS and 20.04 LTS, running on x86_64. Native building for other architectures is not recommended. Support for building under other distributions is limited and not tested. |
Member
|
@clebergnu i'm fine to take the addition of package dependencies. Could you verify that is still needed (and correct names). We're building on 22.04 now. Thanks |
smoser
requested changes
May 8, 2023
Member
smoser
left a comment
smoser
left a comment
There was a problem hiding this comment.
If you can drop the 20.04 comment commit, then the others here are fine and i'll land it.
sorry for way slow review process. :-(
| # Build instructions | ||
|
|
||
| The following works on Ubuntu 18.04 LTS, running on x86_64. Native building for other architectures is not recommended. Support for building under other distributions is limited and not tested. | ||
| The following works on Ubuntu 18.04 LTS and 20.04 LTS, running on x86_64. Native building for other architectures is not recommended. Support for building under other distributions is limited and not tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a couple of updates to build on Ubuntu 20.04 LTS, and cloud-init scripts parameters standardization.