Skip deleting options if columnar.options is already dropped #5458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule.
onurctirtir
force-pushed
the
col/skip-options
branch
from
9b7c673 to
3136e4e
Compare
onurctirtir
commented
Nov 10, 2021
Comment on lines
+340
to
+344
| if (columnarOptions == NULL) | ||
| { | ||
| /* extension has been dropped */ | ||
| return false; | ||
| } |
Member
Author
There was a problem hiding this comment.
as we do in DeleteMetadataRows ...
Codecov Report
@@ Coverage Diff @@
## master #5458 +/- ##
==========================================
- Coverage 92.72% 92.72% -0.01%
==========================================
Files 215 215
Lines 45274 45276 +2
==========================================
- Hits 41981 41980 -1
- Misses 3293 3296 +3 |
JelteF
reviewed
Nov 11, 2021
onurctirtir
commented
Nov 11, 2021
marcocitus
approved these changes
Nov 12, 2021
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule src/test/regress/expected/upgrade_columnar_after.out src/test/regress/sql/upgrade_columnar_after.sql
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule src/test/regress/expected/upgrade_columnar_after.out src/test/regress/sql/upgrade_columnar_after.sql
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule src/test/regress/expected/upgrade_columnar_after.out src/test/regress/sql/upgrade_columnar_after.sql
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule src/test/regress/expected/upgrade_columnar_after.out src/test/regress/sql/upgrade_columnar_after.sql
onurctirtir
added a commit
that referenced
this pull request
Nov 12, 2021
Drop extension might cascade to columnar.options before dropping a columnar table. In that case, we were getting below error when opening columnar.options to delete records for the columnar table that we are about to drop.: "ERROR: could not open relation with OID 0". I somehow reproduced this bug easily when upgrading pg, that is why adding added the test to after_pg_upgrade_schedule. (cherry picked from commit 25024b7) Conflicts: src/test/regress/after_pg_upgrade_schedule src/test/regress/expected/upgrade_columnar_after.out src/test/regress/sql/upgrade_columnar_after.sql
Member
Author
|
(backported to those three branches, so removing labels) |
onurctirtir
added
dev_reported
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Citus might cascade to
columnar.optionsbefore dropping acolumnar table. In that case, we were getting below error when opening
columnar.optionsto delete records for the columnar table that weare about to drop: "ERROR: could not open relation with OID 0".
I somehow reproduced this bug more easily when testing pg upgrade
scenarios, probably because OID's of columnar metadata tables gets
re-written when upgrading pg. That is why I added the test to
after_pg_upgrade_schedule, which easily reproduces the bug after
reverting the fix done in
columnar_metadata.cDESCRIPTION: Fixes a bug that could break
DROP SCHEMA/EXTENSONcommands when there is a columnar table