PG18: GUC file_copy_method behaves as expected. #8379
Merged
+161
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8379 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 287 287
Lines 63020 63019 -1
Branches 7891 7891
==========================================
- Hits 55925 55924 -1
Misses 4778 4778
Partials 2317 2317 🚀 New features to boost your workflow:
|
naisila
approved these changes
Dec 16, 2025
Add tests to check that the GUC `file_copy_method` behaves as expected when database commands are propagated. It is not relevant for CREATE DATABASE .. WITH STRATEGY because citus only supports wal_log here, but ALTER DATABASE .. SET TABLESPACE can use it to determine the OS-level file management.
colm-mchugh
force-pushed
the
colm/pg18-dbguc
branch
from
e9b4da0 to
f95786a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check that the GUC
file_copy_methodbehaves as expected when database commands are propagated. It is not relevant for CREATE DATABASE .. WITH STRATEGY because citus only supports wal_log here, but ALTER DATABASE .. SET TABLESPACE can use it to determine the OS-level file management.