Skip to content

Conversation

@hanefi
Copy link
Member

@hanefi hanefi commented Aug 19, 2022

This PR aims to add support for PG15 beta packages in the CI scripts that are used in pg_auto_failover regression suite.

@gurkanindibay gurkanindibay marked this pull request as draft August 26, 2022 15:01
# packages in one call
result = stat_get_request(
package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 200),
package_list_with_pagination_request_address(PACKAGE_CLOUD_PARAMETERS, 1, 500),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since new azure-gdpr packages were added, I needed to increase the page count

@gurkanindibay gurkanindibay self-assigned this Aug 31, 2022
@gurkanindibay gurkanindibay marked this pull request as ready for review August 31, 2022 14:30
Copy link
Member

@onurctirtir onurctirtir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider addressing my comments before merging



def get_filtered_package_count(session) -> int:
# Since package count for our test repo is lower than 100, we get the total package details by getting all the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100 (in comment) seems outdated then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

gurkanindibay and others added 2 commits September 1, 2022 11:00
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
@gurkanindibay gurkanindibay merged commit f8cac29 into develop Sep 28, 2022
@gurkanindibay gurkanindibay deleted the add-pg15-scripts branch September 28, 2022 11:27
@hanefi hanefi restored the add-pg15-scripts branch September 29, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants