Provide a new plugin for indexing repeating subfields #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `scheming_subfields_index` plugin will group the values of the
same subfields in a text field that will make the values findable.
They are indexed as `extras_{field_name}__{key}`. `extras_*` is a
dynamic `text` Solr field that will allow free-text search on these
values.
Added tests and updated the docs.
wardi
approved these changes
Jul 2, 2024
Contributor
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
Looks great, please resolve conflict and merge. We can keep the scheming_nerf_index plugin in the code but mark is as deprecated and recommend use of scheming_subfields_index instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scheming_subfields_indexplugin will group the values of the same subfields in a text field that will make the values findable.They are indexed as
extras_{field_name}__{key}.extras_*is a dynamictextSolr field that will allow free-text search on thesevalues.
Added tests and updated the docs.
@wardi let me know what do you think and if you want to keep the
scheming_nerf_indexplugin or remove it in favour of this one.Note: the test failure is a Python 2 one, support for which is removed in #413