This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Conversation
This was referenced Jan 31, 2020
oleq
commented
Jan 31, 2020
Contributor
I had a similar feeling about all the command classes. There are two base classes but it is not a big deal to refactor them later if needed. The code duplication at this stage is OK IMO. |
jodator
approved these changes
Feb 3, 2020
Contributor
jodator
left a comment
There was a problem hiding this comment.
I could nitpick to that one thing which I actually change before merging. So there's a green light from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Implemented the table properties form. Closes ckeditor/ckeditor5#6112.
Additional information
CI and the constellation
Requires
FormRowViewandFormHeaderView.Remarks
TablePropertiesUIandTableCellPropertiesUIare very similar (same with the views). At first, I wanted to create a base class (classes) for all of them (and/or a tool to help compose them) but then I figured this may not be the best idea because even though at this moment they are very similar, they may diverge in the future and this will be a situation with an unmaintainable base class (or set of tools).So, long story short, I don't like this huge code duplication (in UI and View classes) but at the same time, I'm worried that extracting the common pieces will not be good in the long run.