This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Conversation
…so it executes when the toolbar shows up again.
…tly in RTL editors.
oleq
reviewed
Apr 8, 2020
oleq
reviewed
Apr 8, 2020
oleq
reviewed
Apr 8, 2020
oleq
suggested changes
Apr 8, 2020
Member
oleq
left a comment
oleq
left a comment
There was a problem hiding this comment.
We're only missing docs about enabling/disabling grouping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: The
BlockToolbarshould group items when there is no place to show them all. Closes ckeditor/ckeditor5#6449. Closes ckeditor/ckeditor5#6575. Closes ckeditor/ckeditor5#6570.Bulletproofed the
ToolbarView#maxWidthand items grouping when the toolbar is invisible.Additional information
This PR closes ckeditor/ckeditor5#6449 but it is related also to the issue ckeditor/ckeditor5/issues/6570.