Removing multiprocess examples from Windows build and simplifying windows build instructions to reflect latest Eigen version #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, removing them from install help.
# Conflicts: # examples/CMakeLists.txt
…be compiled in Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's more convenient to have xor-mp and rnnlm-mp removed from the Windows build altogether, so after running cmake the user just builds the entire solution. Updated cmake file to do this, and updated instructions to clarify.
Also, some of the windows-specific Eigen code changes are no longer needed, they were fixed in the latest version of Eigen, so I removed these from the windows section of the install. There is now just one line they have to change in Eigen, and hopefully eventually we can remove that too.