Skip to content

Small navigation improvements #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckadner merged 7 commits into from
Dec 10, 2021
Merged

Small navigation improvements #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
727a0ac
join the conversation is at the bottom unless you are logged in, wher…
Prasantacharya Oct 15, 2021
2e60f15
add the announcement blog post (#232)
animeshsingh Oct 4, 2021
fbf5e5e
adds space so join the conversation is seperated a bit from the other…
Prasantacharya Oct 15, 2021
b4fd2dd
sidebar now has text (Join the conversation) lined up side by side
Prasantacharya Oct 16, 2021
88c51cc
shifts down the icon slightly so it is inline with text
Prasantacharya Oct 19, 2021
e68e624
Played around with the padding so the icon is center
Prasantacharya Oct 19, 2021
a07d30e
Bullet point is now centered with the icon,
Prasantacharya Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Allows upload, registration, execution, and deployment of:
- Datasets
- Notebooks

For more details about the project please follow this [announcement blog post](https://lfaidata.foundation/blog/2021/09/28/machine-learning-exchange-mlx/).
Copy link
Contributor

@ckadner ckadner Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change here seems unrelated. Could you rebase your PR or merge in the latest changes from main?



<img src="docs/images/mlx.png" height="90%" width="90%">

Additionally it provides:
Expand Down
13 changes: 10 additions & 3 deletions dashboard/origin-mlx/src/components/Sidebar/SidebarList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ function SidebarList() {
const [secretVisible, setSecretVisible] = useState(false)
const { height } = useWindowDimensions()
// Ensures the "Join the Conversation" button is away from the other buttons (if there is enough space)
const guardHeight = height > 700 && !secretVisible ? (height - 670) / 2 : 0
let buffer = !isAdmin ? (height - 600) : (height - 670) / 2 // checks if you are an admin , spacing for guardHeight will change such that elements are placed at the bottom
const guardHeight = height > 700 && !secretVisible ? buffer : 0

console.log(height)

Expand Down Expand Up @@ -119,8 +120,14 @@ function SidebarList() {
<li className="sidebar-list-wrap">
<Link to="/external-links">
<h3 className={`sidebar-list-item ${false ? 'active' : 'not-active'}`}>
<Icon className="sidebar-icon">chat</Icon>
Join the Conversation
<div style={{"display": "flex"}}>
<div style={{"paddingRight": 5, "verticalAlign": "middle"}}>
<Icon className="sidebar-icon" style={{ "marginTop" : 7}}>chat</Icon>
</div>
<div>
<text>Join the Conversation</text>
</div>
</div>
</h3>
</Link>
</li>
Expand Down